Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert alpine #936

Closed
wants to merge 4 commits into from
Closed

Revert alpine #936

wants to merge 4 commits into from

Conversation

aelsabbahy
Copy link
Member

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Alpine integration test is failing consistently as of late. Reverting to old alpine version to see if that resolves the issue.

@aelsabbahy
Copy link
Member Author

Seems re-using :latest is a bad idea since travis-ci seems to cache it now.

Next up will be modifying this PR to use pinned docker tags. image_name:$(sum of dockerfile)

Will also investigate what's causing alpine to behave differently. I wonder if it's as simple as tcp6 🤔

@dklimpel
Copy link
Contributor

-opts=(--env OS=$os --cap-add SYS_ADMIN -v "$PWD/goss:/goss" -d --name "$container_name" --security-opt seccomp:unconfined --security-opt label:disable)
+opts=(--env OS=$os --cap-add SYS_ADMIN -v "$PWD/goss:/goss" -d --name "$container_name" --security-opt seccomp:unconfined --security-opt label:disable --privileged)

I did a lot of tests. Mostly I had localy trouble with this line. Perhaps Travis CI has changed this rights management.

For example: https://github.com/goss-org/goss/pull/908/files#diff-42ccbd89e05a79ca47745ab8cf461626edf35a0cd3429aae34b070a832352b94R39

@dklimpel
Copy link
Contributor

I can reproduce this with GH action. Also with alpine:3.12.

Apache2 does not listen on IPv4. Either port 80 nor 8080. I have no problems on my local machine.

I tried it on port 8080:

Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp        0      0 127.0.0.11:37453        0.0.0.0:*               LISTEN      -
tcp        0      0 0.0.0.0:8888            0.0.0.0:*               LISTEN      -
tcp        0      0 :::8888                 :::*                    LISTEN      -
tcp        0      0 :::8080                 :::*                    LISTEN      168/httpd

@dklimpel dklimpel mentioned this pull request Jun 21, 2024
3 tasks
@aelsabbahy
Copy link
Member Author

fixed by #937

@aelsabbahy aelsabbahy closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants