Update dependencies #974
Merged
Update dependencies #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: R.I.Pienaar <[email protected]>
|
I dont think these failures have anything to do with me change |
|
Probably not, CI is like 95% transitioned to GHA. Going to merge this, looks great! Can you add a link to the mergo sprig issue.. curious to learn more about it. |
aelsabbahy
approved these changes
Sep 14, 2024
|
Mergo renamed itself. Many projects adopted the new name but sprig had no releases for ages. This caused go mode to fail badly fir me sprig and goss were the last dependencies that didn’t move yet so now things should be better |
|
Cool, thanks for the link. I haven't run into too many go dependency quirks.. but perhaps I've just gotten lucky so far. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Dependency updates - mainly to get the new sprig release which in turns resolves a long standing issue after
mergorenamed itself.