cloning node should not clone its children

gosub-io · Sep 27, 2023 · d940e24 · d940e24
1 parent 236a7dd
commit d940e24
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/html5_parser/parser/adoption_agency.rs b/src/html5_parser/parser/adoption_agency.rs
@@ -290,7 +290,7 @@ mod test {
 
         println!("{}", parser.document);
 
-        assert!(true);
+        assert_eq!(true, true);
         // let document = parser.document;
         // let table = document.get_node_by_id(1).unwrap();
         // let tr = document.get_node_by_id(2).unwrap();

diff --git a/src/html5_parser/parser/mod.rs b/src/html5_parser/parser/mod.rs
@@ -3107,7 +3107,7 @@ impl<'a> Html5Parser<'a> {
                 .get_node_by_id(node_id)
                 .expect("node not found")
                 .clone();
-            let new_node_id = self.clone_node(entry_node);
+            let new_node_id = self.clone_node_without_children(entry_node);
 
             self.active_formatting_elements[entry_index] = ActiveElement::NodeId(new_node_id);
 
@@ -3119,8 +3119,10 @@ impl<'a> Html5Parser<'a> {
         }
     }
 
-    fn clone_node(&mut self, org_node: Node) -> usize {
-        let new_node = org_node.clone();
+    fn clone_node_without_children(&mut self, org_node: Node) -> usize {
+        let mut new_node = org_node.clone();
+        new_node.children = Vec::new();
+        new_node.parent = None;
 
         let new_node_id = self.document.add_node(new_node, current_node!(self).id);
         if let NodeData::Element { .. } = org_node.data {