Test Cases added to token.rs #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 more test cases for : is_start_tag(), is_any_start_tag(), is_text_token()
jaytaph
approved these changes
Oct 31, 2023
|
@ankush1233 Thanks for the PR.. Could you check the formatting of the code? This can be done easily by running |
jaytaph
reviewed
Oct 31, 2023
assret --> assert
|
@ankush1233 The assert type is fixed. If you could do a "make fix" so the formatting is correct, we can merge this pr |
emwalker
reviewed
Nov 2, 2023
src/html5/tokenizer/token.rs
Outdated
Comment on lines
244
to
246
| } | ||
| #[test] | ||
| fn test_is_any_start_tag() { |
There was a problem hiding this comment.
Can we add a newline between each test and the one that follows?
Suggested change
| } | |
| #[test] | |
| fn test_is_any_start_tag() { | |
| } | |
| #[test] | |
| fn test_is_any_start_tag() { |
Update token.rs added 3 test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 3 more test cases for : is_start_tag(), is_any_start_tag(), is_text_token()