Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-toolchain.toml #22

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Add rust-toolchain.toml #22

merged 1 commit into from
Sep 24, 2023

Conversation

emwalker
Copy link
Collaborator

This PR adds a rust-toolchain.toml file to give future collaborators guidance on what version of Rust is intended. While we're here, let's pick up some clippy linting issues.

@emwalker emwalker marked this pull request as ready for review September 24, 2023 13:31
@jaytaph
Copy link
Member

jaytaph commented Sep 24, 2023

@emwalker could you sign your commit so I can merge this PR?

@emwalker
Copy link
Collaborator Author

@jaytaph done.

@jaytaph
Copy link
Member

jaytaph commented Sep 24, 2023

@emwalker I think you have to do a rebase on your PR so the old unsigned commit (3b9ec85) will be signed as well.

@emwalker
Copy link
Collaborator Author

I figured that might happen. Rebasing and force pushing shortly.

@emwalker
Copy link
Collaborator Author

Done.

@jaytaph
Copy link
Member

jaytaph commented Sep 24, 2023

@emwalker Thanks for your PR. You've just doubled the amount of contributers to the project :)

@jaytaph jaytaph merged commit 558e3dc into gosub-io:main Sep 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants