add support for class and generic attributes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiyoshika
commented
Nov 4, 2023
| @@ -683,11 +724,8 @@ impl TreeBuilder for DocumentHandle { | |||
| fn insert_attribute(&mut self, key: &str, value: &str, element_id: NodeId) -> Result<()> { | |||
There was a problem hiding this comment.
Ideally I'd like to fetch the node and do the existence/type checks here and pass the node to the other insert methods by reference but couldn't figure out how to properly do it without the borrow checker yelling at me so there's a little bit of code dupe. Open to suggestions
Kiyoshika
commented
Nov 4, 2023
Kiyoshika
force-pushed
the
feat/support-other-attributes
branch
from
49e001b
to
f9f3834
Compare
neuodev
approved these changes
Nov 4, 2023
jaytaph
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extension of my last one where I add support for the
classattribute as well as generic attributes (anything other thanidandclass)