Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated 'make fix' #260

Merged
merged 1 commit into from
Nov 14, 2023
Merged

deprecated 'make fix' #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ build: ## Build the project
section "Cargo build" ;\
cargo build

fix: ## Fix formatting and clippy errors
fix: ## Fix formatting and clippy errors (deprecated)
echo "Use 'make format' instead"

Comment on lines +17 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove the old completely? I mean keeping this has no big benefits I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is for anyone used to using make fix that doesn't see this PR and maybe confused when it's gone. Granted, it's not hard to look at the Makefile but it'll at least tell you it's moved; then maybe just completely remove it at some point

Although I don't have a preference for either way, whether we remove it now or later

format: ## Fix formatting and clippy errors
cargo fmt
cargo clippy --fix --allow-dirty --allow-staged

Expand Down