Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic error handling #261

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add basic error handling #261

merged 1 commit into from
Nov 14, 2023

Conversation

emwalker
Copy link
Collaborator

This PR

  • Implements FromStr for Setting
  • Adds basic error handling to the config store

@emwalker emwalker force-pushed the from-str branch 4 times, most recently from e34775b to fc48cf3 Compare November 14, 2023 03:44
@emwalker emwalker self-assigned this Nov 14, 2023
@emwalker emwalker marked this pull request as ready for review November 14, 2023 03:48
@jaytaph jaytaph merged commit 66d24c4 into main Nov 14, 2023
4 checks passed
@jaytaph jaytaph deleted the from-str branch November 14, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaytaph jaytaph jaytaph approved these changes

Assignees

@emwalker emwalker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emwalker @jaytaph