-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate repo to a Cargo workspace #284
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,19 +12,19 @@ bench: ## Benchmark the project | |
build: ## Build the project | ||
source test-utils.sh ;\ | ||
section "Cargo build" ;\ | ||
cargo build | ||
cargo build --all | ||
|
||
fix: ## Fix formatting and clippy errors (deprecated) | ||
echo "Use 'make format' instead" | ||
|
||
format: ## Fix formatting and clippy errors | ||
cargo fmt | ||
cargo clippy --fix --allow-dirty --allow-staged | ||
cargo fmt --all | ||
cargo clippy --all --fix --allow-dirty --allow-staged | ||
|
||
test_unit: | ||
source test-utils.sh ;\ | ||
section "Cargo test" ;\ | ||
cargo test --features debug_parser | ||
cargo test --all --all-features | ||
|
||
test_clippy: | ||
source test-utils.sh ;\ | ||
|
@@ -34,12 +34,14 @@ test_clippy: | |
test_fmt: | ||
source test-utils.sh ;\ | ||
section "Cargo fmt" ;\ | ||
cargo fmt -- --check | ||
cargo fmt --all -- --check | ||
|
||
test_commands: | ||
cargo run --bin html5-parser-test >/dev/null | ||
cargo run --bin parser-test >/dev/null | ||
cargo run --bin config-store list >/dev/null | ||
cargo run --bin gosub-parser ./tests/data/tree_iterator/stackoverflow.html >/dev/null | ||
cargo run --example html5-parser >/dev/null | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While we're here, let's add two more binaries to the CI run. |
||
|
||
help: ## Display available commands | ||
echo "Available make commands:" | ||
|
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the
--all
flag now to pick upgosub-bindings
. So perhaps good to usemake build
now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could add a target to build only one specific. But it might make sense to do this as a seperate PR