change default compilation mode to release mode for C API #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiyoshika
changed the title
Kiyoshika
commented
Dec 2, 2023
crates/gosub-bindings/Makefile
Outdated
| INCLUDE_DIR := include | ||
| SRC_DIR := src | ||
| CPPFLAGS := -I$(INCLUDE_DIR) -I$(INCLUDE_DIR)/nodes | ||
| CFLAGS_DEBUG := -std=c99 -g -Wall -Wextra -O0 | ||
| CFLAGS_RELEASE := -std=c99 -Wall -Wextra -O2 | ||
| CFLAGS := $(CFLAGS_DEBUG) | ||
| CC := gcc | ||
| TARGET_DIR := ../../target/debug |
There was a problem hiding this comment.
After some testing we also need a way to change this to ../../target/release depending on the mode as well...
|
Ah, my editor was adding random spaces and also make doesn't allow you to tab in conditionals when it's outside of a rule... the format is very picky but I figured it out now |
Kiyoshika
force-pushed
the
c-api-release-mode
branch
from
f356027
to
8f8bb4d
Compare
Co-authored-by: Eric Walker <[email protected]>
Co-authored-by: Eric Walker <[email protected]>
Kiyoshika
force-pushed
the
c-api-release-mode
branch
from
45b61ea
to
ab478f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I was trying to add a variable to determine which mode to use but Make is very annoying and convoluted sometimes that this just made things more complicated than they needed to be. Defaulting to release mode so when the user agent(s) build the bindings, they don't have to change the mode