Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add var in C API makefile to change compilation mode #301

Merged
merged 2 commits into from
Dec 2, 2023
Merged

add var in C API makefile to change compilation mode #301

merged 2 commits into from
Dec 2, 2023

Conversation

Kiyoshika
Copy link
Member

@Kiyoshika Kiyoshika commented Dec 2, 2023 •
edited
Loading

This adds a MODE variable to the makefile in the gosub-bindings to compile in different modes.

By default it will use Release mode (for the user agents when they build the bindings) and for development we can switch to Debug.

make bindings will now also build the crate in the specified mode so we don't have to manually cargo build ourselves

@Kiyoshika Kiyoshika requested a review from a team December 2, 2023 17:37
emwalker
emwalker approved these changes Dec 2, 2023
View reviewed changes
crates/gosub-bindings/README.md Outdated Show resolved Hide resolved
@Kiyoshika Kiyoshika merged commit 4545a1e into main Dec 2, 2023
5 checks passed
@Kiyoshika Kiyoshika deleted the gosub-bindings-makefile branch December 2, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emwalker emwalker emwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kiyoshika @emwalker