improve the C API test #302
Conversation
| double bottom; | ||
| }; | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Looks like the other files have an extra newline except for this one, maybe that's the issue?
There was a problem hiding this comment.
I just switched to a new editor, seems like Zed was autoinserting the newlines at the end but Rust Rover isn't. Didn't know that was a thing
There was a problem hiding this comment.
Not a huge thing. It's the kind of thing editors usually take care of. But because I'm kind of detail oriented, the red circle in the GitHub view always catches my eye.
There was a problem hiding this comment.
Yeah, I just looked it up, apparently having a newline at the end of files has historically been significant (at least for C/C++ files) so Github was probably flagging that. I just fixed it
Kiyoshika
force-pushed
the
improve-c-api-test
branch
from
1cb3dde
to
3c3371d
Compare
Kiyoshika
force-pushed
the
improve-c-api-test
branch
from
3c3371d
to
533f875
Compare
This includes margin and padding (for later) into the
node_tstruct and testing the "public" API instead of the struct internals (since that's how they will be used by user agents.)There's also some slight reorganization such as moving Position struct into the properties (as well as creating a properties.h header that does something similar to kind of mimic the Rust structure)