Add more tests for V8 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharktheone
added
javascript
Sharktheone
force-pushed
the
js/tests
branch
from
0d8a4ab
to
d100cd2
Compare
jaytaph
approved these changes
Feb 25, 2024
Sharktheone
force-pushed
the
js/tests
branch
from
d100cd2
to
5a7bdd6
Compare
This was referenced Feb 26, 2024
Sharktheone
force-pushed
the
js/tests
branch
3 times, most recently
from
597fe08
to
fdfeb77
Compare
jaytaph
approved these changes
Feb 28, 2024
Sharktheone
force-pushed
the
js/tests
branch
from
fdfeb77
to
ec96e13
Compare
Sharktheone
force-pushed
the
js/tests
branch
from
ec96e13
to
24a9295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for V8.
Maybe we should also have tests that aren't specific to V8, so they can be reused.
During writing those, I noticed some things I can still improve about the JS API:
Next Steps