Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly adds another trait
IntoRustValue
, which can convertJSValue
s into the correct Rust types. Because of thatValueConversion
was renamed toIntoJSValue
This makes it way easier to convert JSValues to Rust values in the macro I want to write. I decided to make a separate PR for that because it doesn't really fit to the macro things.
Secondly, slices and
Vec
s can be can be converted to a JSArray and back.JSArray can also be converted to JSValue and
Vec<JSValue>
Finally, I removed the `#[allow(X)] macros and fixed the warnings generated by that.
Next Steps