Add Fetcher
which automatically expands urls
#558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fetcher automatically handles URLs expanding and requesting, so when it encounters a relative URL, it will make use of the base URL and "expands" the URL.
It also handles different schemes, like
https
,http
andfile
we can add more later on.For now, I only make use of it in the image requesting. I guess in the future, we want to build a fetcher, when we download the HTML and pass it to the different subcomponents, like drawing and so on.
The fetcher can then also make some caching, but only for the lifetime of the page, so if we have for example the same image twice on the page, it doesn't try to download it two times but only once.