Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added improvements on the CSS3 user stylesheet parser #562

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Added improvements on the CSS3 user stylesheet parser #562

merged 12 commits into from
Aug 27, 2024

Conversation

jaytaph
Copy link
Member

@jaytaph jaytaph commented Aug 24, 2024 •
edited
Loading

  • The bytestream has an option configuration you can give it.
  • removed confidence property for the bytestream.
  • optimized the bytestream so it doesn't need any more copies
  • bytestream can deal with different encodings (UTF8 / ASCII / UTF16LE / UTF16BE)
  • Implemented some missing parser syntax
  • Fixed location of tokens (they had the wrong line/col)
  • html5 tokenizer and parser returns location information

@jaytaph jaytaph marked this pull request as draft August 24, 2024 14:32
@jaytaph jaytaph added css3 tokenizer Any issues related to the CSS3 tokenizer html5 parser Any issues related to the HTML5 parser html5 tokenizer Any issues related to the HTML5 tokenizer css3 Any issues related to CSS3 labels Aug 27, 2024
@jaytaph jaytaph marked this pull request as ready for review August 27, 2024 10:59
@Sharktheone
Copy link
Member

Sharktheone commented Aug 27, 2024 •
edited
Loading

Hmm... looks like the parse_url test is sus
https://github.com/gosub-io/gosub-engine/actions/runs/10576700889/job/29303510579?pr=562#step:7:617

I guess, we should cancel this run

@jaytaph jaytaph force-pushed the css3-location-fix branch 2 times, most recently from aea5c62 to ed5db39 Compare August 27, 2024 15:46
@jaytaph jaytaph merged commit a74b431 into gosub-io:main Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharktheone Sharktheone Sharktheone approved these changes

Assignees
No one assigned
Labels
css3 tokenizer Any issues related to the CSS3 tokenizer css3 Any issues related to CSS3 html5 parser Any issues related to the HTML5 parser html5 tokenizer Any issues related to the HTML5 tokenizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaytaph @Sharktheone