Syntax matcher walker #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharktheone
previously requested changes
Sep 3, 2024
jaytaph
force-pushed
the
syntax-matcher-walker
branch
from
7091c76
to
c4adcc8
Compare
jaytaph
force-pushed
the
syntax-matcher-walker
branch
from
76a5c49
to
8094bba
Compare
Sharktheone
reviewed
Sep 21, 2024
jaytaph
force-pushed
the
syntax-matcher-walker
branch
2 times, most recently
from
e48b3dc
to
d5504b0
Compare
This is a rather large commit that was needed in order to let the gosub_html5 and gosub_css3 crates to be dependend on eachother. The problem was that they both need eachother and resulted in a cyclic dependency. We solve this usually by moving stuff to the gosub_shared crate, but in this case it would mean we practically move EVERYTHING to that crate. So instead we created a lot of traits in the gosub_shared that can be used by the other crates. This way, both html5 and css3 crates do not need to be depenended on eachother, but only on the gosub_shared crate. However, it crates a lot of extra efford in getting this up and running, the traits and generics means that A LOT of code must be refactored into this system, during which we found out that a lot of code is not on the correct places. We moved around much of the code so it kinda makes sense again. This resulted in the removal of the gosub_styling crate, which was a sort of bridge between the css3-system and other things, which now lives in the css3 crate (which we now properly could manage). There are still problems we're facing, but overal the refactoring looks good. Note that creating this trait setup resulted in redesigning a new engine architecture (unimaginably named "engine_v2"), in which we are redesigning the way we deal with all components. It should resolve all the trait bottlenecks we currently have and hopefully we will be able to refactor the current engine into that one. For now, we keep on working on this system. Co-authored-by: Shark <[email protected]>
jaytaph
force-pushed
the
syntax-matcher-walker
branch
from
d5504b0
to
d3f0c51
Compare
Sharktheone
approved these changes
Sep 29, 2024
Sharktheone
force-pushed
the
syntax-matcher-walker
branch
from
7539947
to
8338cc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.