Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deploy docs to github pages #65

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Conversation

neuodev
Copy link
Collaborator

@neuodev neuodev commented Oct 1, 2023

This patch adds a new job to the GitHub workflow to generate docs and deploy them to GH pages.

The job is only triggered when the PR is merged into the "main" branch. It needs access to the "GITHUB_TOKEN" of the repo owner. It will push the "target/doc" directory to a branch called "gh-pages" in the root directory.

The repo owner will need to update the repo settings to make GitHub deploy to this directory.

@neuodev
Copy link
Collaborator Author

neuodev commented Oct 1, 2023

Screenshot 2023-10-01 at 10 42 34 AM

You will need to update your settings at "settings>pages"

@neuodev
Copy link
Collaborator Author

neuodev commented Oct 1, 2023

Ideally, we should not have the "gh-pages" branch. But it is a good start. we can update it in the future (incremental change)

This patch adds a new job to the GitHub workflow to generate docs and deploy them to GH
pages.

The job is only triggered when the PR is merged into the "main" branch. It needs access
to the "GITHUB_TOKEN" of the repo owner. It will push the "target/doc" directory
to a branch called "gh-pages" in the roo directory.

The repo owner will need to update the repo settings to make GitHub deploy to
this directory.
@jaytaph
Copy link
Member

jaytaph commented Oct 1, 2023

@neuodev Looks good! I'll add this for now, but we might want to deploy to different systems. I have a docs.developer.gosub.io reserved for this, but for now gh-pages is fine. I'll try to make this work now.

@jaytaph jaytaph merged commit 0ee3e99 into gosub-io:main Oct 1, 2023
5 checks passed
@neuodev
Copy link
Collaborator Author

neuodev commented Oct 1, 2023

Screenshot 2023-10-01 at 11 17 06 AM

I can see that the job is skipped for some reason.

@neuodev neuodev deleted the ci-docs branch October 1, 2023 08:17
@neuodev
Copy link
Collaborator Author

neuodev commented Oct 1, 2023

@jaytaph checkout this fix #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants