Implemented an initial setup for the console API #76

jaytaph · 2023-10-02T10:50:26Z

This is an initial setup of the console api, since i cannot spend any time on the parser since I cannot access the code (don't ask).

So therefor, I did some reading up on the console API, and found that it's not very hard to implement. Not everything is done yet, but most is.

The idea is that anything that can be displayed (implements fmt::Display), can be added to the console functions. It also contains timers, and groups.

Ultimately, the console will write to a io::Write, which can be stdout(), a file, or a string buffer. Later on, these calls will be connected to javascript methods.

I'm not sure if this is the right way to do it, so i'm hoping from some feedback from others to see if this is the right way to do it.

(i know that the console api is not the highest priority, but it gave me some time to read into more stuff, and practice some rust)

Cargo.toml

src/console/buffer_printer.rs

src/console/formatter.rs

src/console/mod.rs

src/console/text_printer.rs

jaytaph · 2023-10-04T06:28:02Z

@emwalker Thanks for the feedback. I've implemented the suggestions, and will try to implement the rest of the code. I might even check if it would be possible if I could create some node.js bindings, to see if I can use it from node.js, but this depends on my time available (i really want the parser done)

emwalker · 2023-10-07T18:58:49Z

src/api/console/buffer.rs

+impl Write for Buffer {
+    fn write(&mut self, buf: &[u8]) -> std::io::Result<usize> {
+        self.buf.extend(buf);
+        Ok(buf.len())


Did you want to fix this return value before merging? If not, perhaps add a // TODO: return correct return value.

emwalker · 2023-10-07T19:00:54Z

LGTM with suggestion.

jaytaph force-pushed the console-api branch from 77a0cc2 to 817aa72 Compare October 2, 2023 10:53

jaytaph marked this pull request as draft October 2, 2023 10:54