forked from raystack/compass
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: change flow of deletion assets and refactor codes based on feed…
…backs
- Loading branch information
Muhammad Luthfi Fahlevi
committed
Aug 20, 2024
1 parent
4abd20d
commit a77cf72
Showing
29 changed files
with
294 additions
and
372 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 35 additions & 17 deletions
52
pkg/query_expr/delete_asset_expr.go → core/asset/delete_asset_expr.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,68 @@ | ||
| package queryexpr | ||
| package asset | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/goto/compass/core/asset" | ||
| generichelper "github.com/goto/compass/pkg/generic_helper" | ||
| "github.com/goto/compass/pkg/queryexpr" | ||
| ) | ||
|
|
||
| var assetJSONTagsSchema = generichelper.GetJSONTags(Asset{}) | ||
|
|
||
| type DeleteAssetExpr struct { | ||
| ExprStr | ||
| queryexpr.ExprStr | ||
| } | ||
|
|
||
| func (d DeleteAssetExpr) ToQuery() (string, error) { | ||
| return d.ExprStr.ToQuery() | ||
| } | ||
|
|
||
| func (d DeleteAssetExpr) Validate() error { | ||
| identifiersWithOperator, err := GetIdentifiersMap(d.ExprStr.String()) | ||
| identifiersWithOperator, err := queryexpr.GetIdentifiersMap(d.ExprStr.String()) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| isExist := func(jsonTag string) bool { | ||
| return identifiersWithOperator[jsonTag] != "" | ||
| } | ||
| mustExist := isExist("refreshed_at") && isExist("type") && isExist("service") | ||
| if !mustExist { | ||
| return fmt.Errorf("must exists these identifiers: refreshed_at, type, and service") | ||
| if err := d.isRequiredIdentifiersExist(identifiersWithOperator); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| isOperatorEqualsOrIn := func(jsonTag string) bool { | ||
| return identifiersWithOperator[jsonTag] == "==" || strings.ToUpper(identifiersWithOperator[jsonTag]) == "IN" | ||
| } | ||
| if !isOperatorEqualsOrIn("type") || !isOperatorEqualsOrIn("service") { | ||
| return fmt.Errorf("identifier type and service must be equals (==) or IN operator") | ||
| if err := d.isUsingRightOperator(identifiersWithOperator); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return d.isAllIdentifiersExistInStruct(identifiersWithOperator) | ||
| } | ||
|
|
||
| func (DeleteAssetExpr) isAllIdentifiersExistInStruct(identifiersWithOperator map[string]string) error { | ||
| identifiers := generichelper.GetMapKeys(identifiersWithOperator) | ||
| jsonTagsSchema := generichelper.GetJSONTags(asset.Asset{}) | ||
| for _, identifier := range identifiers { | ||
| isFieldValid := generichelper.Contains(jsonTagsSchema, identifier) | ||
| isFieldValid := generichelper.Contains(assetJSONTagsSchema, identifier) | ||
| if !isFieldValid { | ||
| return fmt.Errorf("%s is not a valid identifier", identifier) | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (DeleteAssetExpr) isUsingRightOperator(identifiersWithOperator map[string]string) error { | ||
| isOperatorEqualsOrIn := func(jsonTag string) bool { | ||
| return identifiersWithOperator[jsonTag] == "==" || strings.ToUpper(identifiersWithOperator[jsonTag]) == "IN" | ||
| } | ||
| if !isOperatorEqualsOrIn("type") || !isOperatorEqualsOrIn("service") { | ||
| return fmt.Errorf("identifier type and service must be equals (==) or IN operator") | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (DeleteAssetExpr) isRequiredIdentifiersExist(identifiersWithOperator map[string]string) error { | ||
| isExist := func(jsonTag string) bool { | ||
| return identifiersWithOperator[jsonTag] != "" | ||
| } | ||
| mustExist := isExist("refreshed_at") && isExist("type") && isExist("service") | ||
| if !mustExist { | ||
| return fmt.Errorf("must exists these identifiers: refreshed_at, type, and service") | ||
| } | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package asset | ||
|
|
||
| type DeleteAssetsRequest struct { | ||
| QueryExpr string | ||
| DryRun bool | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.