Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sync asset handlers #68

Merged
merged 6 commits into from
Dec 11, 2023
Merged

feat: add sync asset handlers #68

merged 6 commits into from
Dec 11, 2023

Conversation

batrov
Copy link

@batrov batrov commented Dec 4, 2023 •
edited
Loading

Add a sync assets functionality to sync ES data with compass DB (postgres) as source of truth

related issue: #67

@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7125857120

  • 93 of 307 (30.29%) changed or added relevant lines in 9 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.3%) to 85.234%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/worker/worker.go 0 3 0.0%
core/asset/service.go 0 6 0.0%
internal/workermanager/in_situ_worker.go 1 30 3.33%
internal/workermanager/discovery_worker.go 10 56 17.86%
pkg/worker/pgq/pgq_processor.go 0 46 0.0%
internal/store/elasticsearch/discovery_repository.go 64 148 43.24%
Files with Coverage Reduction New Missed Lines %
internal/store/postgres/asset_repository.go 1 80.33%
internal/workermanager/in_situ_worker.go 1 34.78%
Totals Coverage Status
Change from base Build 6891020347: -2.3%
Covered Lines: 6332
Relevant Lines: 7429
💛 - Coveralls

@batrov batrov marked this pull request as draft December 4, 2023 12:17
haveiss
haveiss requested changes Dec 5, 2023
View reviewed changes
core/asset/discovery.go Outdated Show resolved Hide resolved
internal/server/v1beta1/asset.go Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
bsushmith
bsushmith reviewed Dec 5, 2023
View reviewed changes
core/job/job.go Outdated Show resolved Hide resolved
@batrov batrov force-pushed the sync-asset branch 3 times, most recently from ddeb83d to ef0115f Compare December 5, 2023 08:02
@batrov batrov marked this pull request as ready for review December 7, 2023 05:31
haveiss
haveiss reviewed Dec 7, 2023
View reviewed changes
core/job/job.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository.go Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository_test.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/es_test.go Show resolved Hide resolved
@batrov batrov merged commit f07825f into main Dec 11, 2023
4 checks passed
@batrov batrov deleted the sync-asset branch December 11, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haveiss haveiss haveiss approved these changes

@bsushmith bsushmith bsushmith approved these changes

@anjali9791 anjali9791 anjali9791 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@batrov @coveralls @haveiss @bsushmith @anjali9791