feat: make time out in delete assets to be configurable #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2024 13:45
haveiss
reviewed
Sep 2, 2024
luthfifahlevi
force-pushed
the
feat-configurable-time-out-in-delete-assets
branch
from
81f5ad7
to
9ee9390
Compare
Pull Request Test Coverage Report for Build 10666882632Details
💛 - Coveralls |
luthfifahlevi
force-pushed
the
feat-configurable-time-out-in-delete-assets
branch
from
dbad4f8
to
0f0b609
Compare
irainia
approved these changes
Sep 2, 2024
haveiss
reviewed
Sep 2, 2024
cli/server.go
Outdated
| LineageRepo: lineageRepository, | ||
| Worker: wrkr, | ||
| Logger: logger, | ||
| DeleteAssetsTimeout: cfg.Asset.DeleteAssetsTimeout, |
There was a problem hiding this comment.
let's pass the cfg altogether
haveiss
reviewed
Sep 2, 2024
haveiss
reviewed
Sep 2, 2024
core/asset/service.go
Outdated
| @@ -19,6 +19,7 @@ type Service struct { | |||
| lineageRepository LineageRepository | |||
| worker Worker | |||
| logger log.Logger | |||
| assetConfig Config | |||
There was a problem hiding this comment.
let's avoid unnecessary context, we can use config as name
Suggested change
| assetConfig Config | |
| config Config |
luthfifahlevi
force-pushed
the
feat-configurable-time-out-in-delete-assets
branch
from
d4b7f54
to
fbc4a5e
Compare
haveiss
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.