feat: add flink module #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add test cases for this? |
mabdh
reviewed
Sep 2, 2024
ishanarya0
force-pushed
the
flink-module
branch
from
e5f89f0
to
8ca3702
Compare
mabdh
reviewed
Sep 10, 2024
Comment on lines
+62
to
+77
| /* | ||
| s.Run("create flink with invalid config will return invalid error", func() { | ||
| _, err := s.resourceClient.CreateResource(s.ctx, &entropyv1beta1.CreateResourceRequest{ | ||
| Resource: &entropyv1beta1.Resource{ | ||
| Name: "test-flink", | ||
| Project: "test-project", | ||
| Kind: "flink", | ||
| Spec: &entropyv1beta1.ResourceSpec{ | ||
| Configs: structpb.NewStringValue("{}"), | ||
| Dependencies: []*entropyv1beta1.ResourceDependency{}, | ||
| }, | ||
| }, | ||
| }) | ||
| s.Assert().Equal(codes.InvalidArgument, status.Convert(err).Code()) | ||
| }) | ||
| */ |
There was a problem hiding this comment.
can we clean this up if not needed?
ishanarya0
force-pushed
the
flink-module
branch
from
a02064e
to
1a06848
Compare
* feat: add dagger module * feat: add flink dep * feat: add transformations * fix: read stream from config root * feat: add Plan implementation * fix: chart values * fix: resolve TODOs and refactored * fix: source sink base handling * feat: Output to have CR details * feat: handle status * refactor: seperate contants by type * refactor: kubeGetCRD function * feat: add dagger update action * fix: add Update action * chore: change var name to sink_kafka_stream * feat: merge consumer group ID if sink is same --------- Co-authored-by: Ishan Arya <[email protected]>
* feat: add dagger module * feat: add flink dep * feat: add transformations * fix: read stream from config root * feat: add Plan implementation * fix: chart values * fix: resolve TODOs and refactored * fix: source sink base handling * feat: Output to have CR details * feat: handle status * refactor: seperate contants by type * refactor: kubeGetCRD function * feat: add dagger update action * fix: add Update action * chore: change var name to sink_kafka_stream * feat: merge consumer group ID if sink is same * feat: add start, stop and reset actions (#112) * feat: add start & update action * feat: add reset action --------- Co-authored-by: Ishan Arya <[email protected]> --------- Co-authored-by: Ishan Arya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a module named flink
This will be used by dagger to resolve the following details:
A dagger would have only flink module as its dependency.
Note: The dependecy would look like this