feat(otelhttpclient): move generic otelclient from meteor to salt #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumslim
changed the title
haveiss
approved these changes
May 30, 2024
mabdh
reviewed
May 30, 2024
go.mod
Outdated
| go 1.16 | ||
| go 1.21 | ||
|
|
||
| toolchain go1.21.8 |
mabdh
reviewed
May 30, 2024
mabdh
reviewed
May 30, 2024
telemetry/otelgrpc/otelgrpc.go
Outdated
| attributes []attribute.KeyValue | ||
| } | ||
|
|
||
| func NewOtelGRPCMonitor(hostName string) Monitor { |
There was a problem hiding this comment.
Suggested change
| func NewOtelGRPCMonitor(hostName string) Monitor { | |
| func NewMeter(hostName string, MeterOpts...) Monitor { |
We should define a MeterOpts to make it optional to pass meter name so creating a new meter would be
otelgrpc.NewMeter("host", otelgrpc.WithMeterName("github.com/goto/compass"))
mabdh
reviewed
May 30, 2024
telemetry/otelgrpc/otelgrpc.go
Outdated
| Err error | ||
| } | ||
|
|
||
| type Monitor struct { |
There was a problem hiding this comment.
Suggested change
| type Monitor struct { | |
| type Meter struct { |
mabdh
reviewed
May 30, 2024
telemetry/otelgrpc/otelgrpc.go
Outdated
Comment on lines
66
to
67
| size := proto.Size(p.(proto.Message)) | ||
| return size |
There was a problem hiding this comment.
should we make it safer?
Suggested change
| size := proto.Size(p.(proto.Message)) | |
| return size | |
| if pm, ok := p.(proto.Message); ok { | |
| return proto.Size(pm) | |
| } | |
| return 0 |
mabdh
reviewed
May 30, 2024
mabdh
reviewed
May 30, 2024
telemetry/otelgrpc/otelgrpc.go
Outdated
| return size | ||
| } | ||
|
|
||
| func (m *Monitor) RecordUnary(ctx context.Context, p UnaryParams) { |
There was a problem hiding this comment.
if we don't use this outside, make it private
Suggested change
| func (m *Monitor) RecordUnary(ctx context.Context, p UnaryParams) { | |
| func (m *Monitor) recordUnary(ctx context.Context, p UnaryParams) { |
mabdh
reviewed
May 30, 2024
telemetry/otelgrpc/otelgrpc_test.go
Outdated
| "testing" | ||
| "time" | ||
|
|
||
| pb "github.com/goto/optimus/protos/gotocompany/optimus/core/v1beta1" |
There was a problem hiding this comment.
should use sample proto/server for this
commonv1 "github.com/goto/salt/server/example/proto/gotocompany/common/v1"
mabdh
reviewed
May 31, 2024
mabdh
reviewed
May 31, 2024
telemetry/otelgrpc/otelgrpc.go
Outdated
| } | ||
|
|
||
| func NewMeter(hostName string, meterOpts ...MeterOpts) Meter { | ||
| meter := otel.Meter("github.com/goto/salt/telemetry/otelgrpc") |
There was a problem hiding this comment.
The name should not be fixed like this. The one that uses library should be able to configure this
mabdh
reviewed
Jun 4, 2024
mabdh
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating generic otelhttpclient library from meteor to salt, for making it available for other repo to use it and avoid duplication