Skip to content

Commit

Permalink
Fix README.rst that broke the build (#80)
Browse files Browse the repository at this point in the history
  • Loading branch information
gouline authored Nov 28, 2021
1 parent b52fbb5 commit 3fc88e9
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 10 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- uses: actions/setup-python@v2
with:
python-version: '3.6.x'
python-version: "3.6.x"

- name: Requirements
run: make requirements
Expand All @@ -27,8 +27,11 @@ jobs:
- name: Formatting check (black)
run: make check-fmt

- name: Lint check (pylint)
run: make check-lint
- name: Lint Python check (pylint)
run: make check-lint-python

- name: Lint reStructuredText check (rst-lint)
run: make check-lint-rst

- name: Type check (mypy)
run: make check-type
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

- uses: actions/setup-python@v2
with:
python-version: '3.6.x'
python-version: "3.6.x"

- uses: actions/cache@v2
with:
Expand All @@ -31,8 +31,11 @@ jobs:
- name: Formatting check (black)
run: make check-fmt

- name: Lint check (pylint)
run: make check-lint
- name: Lint Python check (pylint)
run: make check-lint-python

- name: Lint reStructuredText check (rst-lint)
run: make check-lint-rst

- name: Type check (mypy)
run: make check-type
Expand Down
11 changes: 9 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,21 @@ check-fmt:
black --check .
.PHONY: check-fmt

check-lint:
check-lint-python:
pylint dbtmetabase
.PHONY: check-lint
.PHONY: check-lint-python

check-lint-rst:
pylint dbtmetabase
.PHONY: check-lint-rst

check-type:
mypy dbtmetabase
.PHONY: check-type

check: check-fmt check-lint-python check-lint-rst check-type
.PHONY: check

test:
python3 -m unittest tests
.PHONY: test
Expand Down
4 changes: 2 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@ Here are the visibility types supported by Metabase:

If you notice new ones, please submit a PR to update this readme.

Model extra fields
----------------
Model Extra Fields
------------------

In addition to the model description, Metabase accepts two extra information fields. Those optional
fields are called ``caveats`` and ``points_of_interest`` and can be defined under the ``meta`` tag
Expand Down
1 change: 1 addition & 0 deletions requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ mypy
types-requests
types-PyYAML
black
restructuredtext-lint

0 comments on commit 3fc88e9

Please sign in to comment.