feat: remove startMonth and endMonth default constraints when dropdown-months is set as caption layout
#2648
+407
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove default values when captionLayout equal to dropdown-months.
|
rodgobbi Thanks for sharing this. |
gpbl
changed the title
startMonth and endMonth default constraints when dropdown-months is set as caption layout
|
Awesome 👏 Thanks so much @rodgobbi 🥇 |
gpbl
added a commit
that referenced
this pull request
Dec 29, 2024
gpbl
added a commit
that referenced
this pull request
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Remove
startMonthandendMonthdefault values whencaptionLayoutequal todropdown-monthsbased on the discussion at #2618 (comment).Type of Change
Demo
dropdown-months.update.mov