Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getCurrentTexture test to match spec. #3311

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

greggman
Copy link
Contributor

It's not entirely clear from the current WebGPU spec if "modified" = setting to the same dimensions. It seems like that shouldn't matter and is inconsistent with other canvas contents.

Note: This fails in Chrome


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from toji January 24, 2024 06:21
@greggman greggman force-pushed the get-current-texture-same-dimensions branch from 347cad8 to cd8f77e Compare January 24, 2024 06:34
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd request that we restore a removed test.

It's not entirely clear from the current WebGPU spec if "modified" = setting
to the same dimensions. It seems like that shouldn't matter and is inconsistent with
other canvas contents.
@greggman greggman force-pushed the get-current-texture-same-dimensions branch from cd8f77e to 1157db7 Compare January 25, 2024 23:47
@greggman greggman merged commit e5c09e6 into gpuweb:main Jan 26, 2024
1 check passed
@greggman greggman deleted the get-current-texture-same-dimensions branch January 26, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants