Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textureBarrier() to uniformity tests #3326

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

jrprice
Copy link
Contributor

@jrprice jrprice commented Jan 25, 2024

Only if the language feature is supported.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@jrprice jrprice added the wgsl label Jan 25, 2024
@jrprice jrprice requested a review from alan-baker January 25, 2024 19:14
@jrprice jrprice merged commit 8109bfd into gpuweb:main Jan 25, 2024
1 check passed
@jrprice jrprice deleted the textureBarrier branch January 25, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants