Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Fix storage texture read_write test #3328

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

greggman
Copy link
Contributor

The test used 256 invocations but compat only supports 128


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from shrekshao January 25, 2024 21:10
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

greggman and others added 2 commits January 26, 2024 06:55
The test used 256 invocations but compat only supports 128
@greggman greggman force-pushed the compat-storage-textures-read-write branch from e8b992f to e3d0545 Compare January 25, 2024 21:55
@greggman greggman enabled auto-merge (squash) January 25, 2024 21:55
@greggman greggman merged commit 49dd714 into gpuweb:main Jan 25, 2024
1 check passed
@greggman greggman deleted the compat-storage-textures-read-write branch January 25, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants