Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Fix depth bias test #3329

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

greggman
Copy link
Contributor

Using a depthStencilAttachment requires depthWriteEnabled and depthCompare set


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Using a depthStencilAttachment requires depthWriteEnabled and depthCompare set
@greggman greggman requested a review from shrekshao January 25, 2024 21:28
@greggman
Copy link
Contributor Author

It scares me that I somehow was able to check this in. I'm 99.999% sure I tested it but it should have failed locally before this change. It did fail locally today, before this change, I'm saying I don't know how it didn't fail back when I wrote this test.

Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greggman greggman merged commit 85bbfe1 into gpuweb:main Jan 25, 2024
1 check passed
@greggman greggman deleted the compat-depth-bias-check branch January 25, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants