Compat: Fix readonly depth-stencil sampling #3330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not entirely clear to me what we should do here. For now, the failing tests are skipped in compat mode
The current compat spec says you can't have 2 different TEXTURE_BINDING views with different settings for the same texture. So you can't view a depth-stencil texture as both an
aspect: 'stencil-only'
in one view andaspect: 'depth-only'
in another view in the same draw call.You can view them as one or the other in separate draw calls. Should we add a path that uses 2 draw calls? If so, can that be a separate PR?
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.