Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Fix readonly depth-stencil sampling #3330

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Jan 25, 2024

It's not entirely clear to me what we should do here. For now, the failing tests are skipped in compat mode

The current compat spec says you can't have 2 different TEXTURE_BINDING views with different settings for the same texture. So you can't view a depth-stencil texture as both an aspect: 'stencil-only' in one view and aspect: 'depth-only' in another view in the same draw call.

You can view them as one or the other in separate draw calls. Should we add a path that uses 2 draw calls? If so, can that be a separate PR?


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from shrekshao January 25, 2024 21:48
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can view them as one or the other in separate draw calls. Should we add a path that uses 2 draw calls? If so, can that be a separate PR?

Sounds reasonable.

LGTM

@greggman greggman force-pushed the compat-ro-depth-stencil branch from 1951d13 to c96aba7 Compare January 25, 2024 22:16
@greggman greggman merged commit 25773c0 into gpuweb:main Jan 25, 2024
1 check passed
@greggman greggman deleted the compat-ro-depth-stencil branch January 25, 2024 22:20
@Kangz
Copy link
Collaborator

Kangz commented Jan 26, 2024

Whoops I should have thought of compat, thanks for looking into that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants