Compat: update maxXXXInYYYStage tests #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekshao
approved these changes
Jan 31, 2025
| .desc( | ||
| `Test that adapter.limit.${limit} and requiredLimits.${limit} must be <= ${dependentLimitName}` | ||
| `Test that | ||
| * adapter.limit.${limit} < adapter.limit${dependentLimitName} |
There was a problem hiding this comment.
nit: adapter.limit.${dependentLimitName}
(missing a dot)
src/webgpu/api/validation/capability_checks/limits/limit_utils.ts
Outdated
Show resolved
Hide resolved
The proposal changed so that the corresponding PerStage limit is auto-upgraded so these tests need to change.
greggman
force-pushed
the
compat-new-maxXXXinStage
branch
from
3dbb2f3 to
ec04d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal changed so that the corresponding PerStage limit is auto-upgraded so these tests need to change.