Fix readTextureToTexelViews for cubemaps #4177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the code that reads back the texture uses textureGather for cubemaps. It has to use textureGather because it's the only way to load from cubemaps with integer formats. It was computing a texel coord and then doing the common conversion to normalized texture coord
normalizedCoord = (integerTexelCoord + 0.5) / dimension
But, for textureGather, 0.5 is the center of the texel and so it's an edge case. The gather could go in any direction from the center. Moving it off center should fix that issue.
Given coord C in the center of a texel
textureGather could return any of these 4 results
if we move it off center
Then it will always return the same result