Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rgba32float on compat related comment #4180

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix rgba32float on compat related comment #4180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/webgpu/shader/execution/shader_io/fragment_builtins.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,9 +528,8 @@ function computeSampleMask({ sampleMask }: FragData) {
* backends like M1 Mac so it seems better to stick to rgba8unorm here and test
* using a storage buffer in a fragment shader separately.
*
* We can't use rgba32float because it's optional. We can't use rgba16float
* because it's optional in compat. We can't we use rgba32uint as that can't be
* multisampled.
* We can't use rgba32float, nor rgba16float, nor rgba32uint as they can't be
* multisampled in all feature levels.
*/
async function renderFragmentShaderInputsTo4TexturesAndReadbackValues(
t: GPUTest,
Expand Down