Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect end tags #5047

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix incorrect end tags #5047

merged 1 commit into from
Jan 22, 2025

Conversation

kainino0x
Copy link
Contributor

This fixes the legit typos, but the spec still doesn't build due to speced/bikeshed#3012

@kainino0x kainino0x added copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) api WebGPU API labels Jan 21, 2025
@kainino0x kainino0x added this to the Milestone 1 milestone Jan 21, 2025
@kainino0x kainino0x requested a review from toji January 21, 2025 21:56
toji
toji approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ugh on the argumentdef issue. I'm pretty happy with how those are formatted today.

@kainino0x kainino0x merged commit d53c4c1 into gpuweb:main Jan 22, 2025
2 of 4 checks passed
@kainino0x kainino0x deleted the bikeshed-fixes branch January 22, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

Assignees
No one assigned
Labels
api WebGPU API copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.
2 participants
@kainino0x @toji