Format backend with latest ruff (#10470)

* format * add changeset * more ruff * changes * update --------- Co-authored-by: gradio-pr-bot <[email protected]>
gradio-app · Jan 30, 2025 · 3465fdb · 3465fdb
1 parent ef66fe5
commit 3465fdb
Show file tree

Hide file tree

Showing 16 changed files with 62 additions and 50 deletions.
diff --git a/.changeset/dirty-ads-yell.md b/.changeset/dirty-ads-yell.md
@@ -0,0 +1,6 @@
+---
+"gradio": minor
+"gradio_client": minor
+---
+
+feat:Format backend with latest `ruff`
diff --git a/client/python/gradio_client/client.py b/client/python/gradio_client/client.py
@@ -764,7 +764,7 @@ def _render_endpoints_info(
                 default_value = info.get("parameter_default")
                 default_value = utils.traverse(
                     default_value,
-                    lambda x: f"handle_file(\"{x['url']}\")",
+                    lambda x: f'handle_file("{x["url"]}")',
                     utils.is_file_obj_with_meta,
                 )
                 default_info = (
@@ -996,7 +996,7 @@ def deploy_discord(
             space_id = huggingface_hub.get_full_repo_name(to_id, token=hf_token)
         else:
             if self.space_id:
-                space_id = f'{self.space_id.split("/")[1]}-gradio-discord-bot'
+                space_id = f"{self.space_id.split('/')[1]}-gradio-discord-bot"
             else:
                 space_id = f"gradio-discord-bot-{secrets.token_hex(4)}"
             space_id = huggingface_hub.get_full_repo_name(space_id, token=hf_token)

diff --git a/client/python/gradio_client/documentation.py b/client/python/gradio_client/documentation.py
@@ -336,13 +336,13 @@ def generate_documentation():
                 classes_inherit_documentation[cls] = cls_documentation["fns"]
     for mode, class_list in classes_to_document.items():
         for i, (cls, _) in enumerate(class_list):
-            for super_class in classes_inherit_documentation:
+            for super_class, fns in classes_inherit_documentation.items():
                 if (
                     inspect.isclass(cls)
                     and issubclass(cls, super_class)
                     and cls != super_class
                 ):
-                    for inherited_fn in classes_inherit_documentation[super_class]:
+                    for inherited_fn in fns:
                         inherited_fn = dict(inherited_fn)
                         try:
                             inherited_fn["description"] = extract_instance_attr_doc(

diff --git a/gradio/blocks.py b/gradio/blocks.py
@@ -2826,8 +2826,7 @@ def integrate(
                 )
             else:
                 print(
-                    "The WandB integration requires you to "
-                    "`launch(share=True)` first."
+                    "The WandB integration requires you to `launch(share=True)` first."
                 )
         if mlflow is not None:
             analytics_integration = "MLFlow"

diff --git a/gradio/cli/commands/components/_docs_utils.py b/gradio/cli/commands/components/_docs_utils.py
@@ -689,17 +689,21 @@ def render_class_docs(exports, docs):
 ### Initialization
 \"\"\", elem_classes=["md-custom"], header_links=True)
 
-    gr.ParamViewer(value=_docs["{class_name}"]["members"]["__init__"], linkify={list(linkify.keys())})
+    gr.ParamViewer(value=_docs["{class_name}"]["members"]["__init__"], linkify={
+            list(linkify.keys())
+        })
 
 {render_class_events(docs[class_name].get("events", None), class_name)}
 
-{make_user_fn(
-    class_name,
-    user_fn_input_type,
-    user_fn_input_description,
-    user_fn_output_type,
-    user_fn_output_description,
-)}
+{
+            make_user_fn(
+                class_name,
+                user_fn_input_type,
+                user_fn_input_description,
+                user_fn_output_type,
+                user_fn_output_description,
+            )
+        }
 """
     return docs_classes
 
@@ -752,7 +756,7 @@ def render_param_table(params):
 
 </td>
 <td align="left"><code>{param["default"]}</code></td>
-<td align="left">{param['description']}</td>
+<td align="left">{param["description"]}</td>
 </tr>
 """
     return table + "</tbody></table>"
@@ -783,12 +787,14 @@ def render_class_docs_markdown(exports, docs):
 
 {render_class_events_markdown(docs[class_name].get("events", None))}
 
-{make_user_fn_markdown(
-    user_fn_input_type,
-    user_fn_input_description,
-    user_fn_output_type,
-    user_fn_output_description,
-)}
+{
+            make_user_fn_markdown(
+                user_fn_input_type,
+                user_fn_input_description,
+                user_fn_output_type,
+                user_fn_output_description,
+            )
+        }
 """
     return docs_classes
 
@@ -873,7 +879,7 @@ def make_space(
 {docs_classes}
 
 {render_additional_interfaces(docs["__meta__"]["additional_interfaces"])}
-    demo.load(None, js=r\"\"\"{make_js(get_deep(docs, ["__meta__", "additional_interfaces"]),get_deep( docs, ["__meta__", "user_fn_refs"]))}
+    demo.load(None, js=r\"\"\"{make_js(get_deep(docs, ["__meta__", "additional_interfaces"]), get_deep(docs, ["__meta__", "user_fn_refs"]))}
 \"\"\")
 
 demo.launch()

diff --git a/gradio/components/video.py b/gradio/components/video.py
@@ -521,7 +521,7 @@ async def combine_stream(
         command = [
             "ffmpeg",
             "-i",
-            f'concat:{"|".join(ts_files)}',
+            f"concat:{'|'.join(ts_files)}",
             "-y",
             "-safe",
             "0",

diff --git a/gradio/external.py b/gradio/external.py
@@ -316,7 +316,7 @@ def custom_post_binary(data):
     elif p == "zero-shot-classification":
         inputs = [
             components.Textbox(label="Input"),
-            components.Textbox(label="Possible class names (" "comma-separated)"),
+            components.Textbox(label="Possible class names (comma-separated)"),
             components.Checkbox(label="Allow multiple true classes"),
         ]
         outputs = components.Label(label="Classification")

diff --git a/gradio/interface.py b/gradio/interface.py
@@ -809,18 +809,18 @@ def attach_clear_events(
             None,
             [],
             ([input_component_column] if input_component_column else []),  # type: ignore
-            js=f"""() => {json.dumps(
-
-                    [{'variant': None, 'visible': True, '__type__': 'update'}]
+            js=f"""() => {
+                json.dumps(
+                    [{"variant": None, "visible": True, "__type__": "update"}]
                     if self.interface_type
-                       in [
-                           InterfaceTypes.STANDARD,
-                           InterfaceTypes.INPUT_ONLY,
-                           InterfaceTypes.UNIFIED,
-                       ]
+                    in [
+                        InterfaceTypes.STANDARD,
+                        InterfaceTypes.INPUT_ONLY,
+                        InterfaceTypes.UNIFIED,
+                    ]
                     else []
-
-            )}
+                )
+            }
             """,
         )
 

diff --git a/gradio/processing_utils.py b/gradio/processing_utils.py
@@ -648,7 +648,7 @@ def _add_root_url(file_dict: dict):
             file_dict["url"] = file_dict["url"][len(previous_root_url) :]
         elif client_utils.is_http_url_like(file_dict["url"]):
             return file_dict
-        file_dict["url"] = f'{root_url}{file_dict["url"]}'
+        file_dict["url"] = f"{root_url}{file_dict['url']}"
         return file_dict
 
     return client_utils.traverse(data, _add_root_url, client_utils.is_file_obj_with_url)

diff --git a/gradio/route_utils.py b/gradio/route_utils.py
@@ -590,7 +590,7 @@ def on_headers_finished(self) -> None:
             )
         except KeyError as e:
             raise MultiPartException(
-                'The Content-Disposition header field "name" must be ' "provided."
+                'The Content-Disposition header field "name" must be provided.'
             ) from e
         if b"filename" in options:
             self._current_files += 1

diff --git a/gradio/themes/builder_app.py b/gradio/themes/builder_app.py
@@ -256,9 +256,9 @@ def get_doc_theme_var_groups():
                 for variable in flat_variables:
                     if variable.endswith("_dark"):
                         continue
-                    for style_type in variable_suggestions:
+                    for style_type, suggestions in variable_suggestions.items():
                         if style_type in variable:
-                            variable_suggestions[style_type].append("*" + variable)
+                            suggestions.append("*" + variable)
                             break
 
                 variable_suggestions["fill"], variable_suggestions["color"] = (
@@ -676,7 +676,7 @@ def generate_theme_code(
                 for var_name in core_var_names:
                     if var_name in specific_core_diffs:
                         cls, vals = specific_core_diffs[var_name]
-                        core_diffs_code += f"""    {var_name}=gr.themes.{cls.__name__}({', '.join(f'''{k}="{v}"''' for k, v in vals.items())}),\n"""
+                        core_diffs_code += f"""    {var_name}=gr.themes.{cls.__name__}({", ".join(f'''{k}="{v}"''' for k, v in vals.items())}),\n"""
                     elif var_name in core_diffs:
                         var_val = core_diffs[var_name]
                         if var_name.endswith("_size"):
@@ -706,7 +706,7 @@ def generate_theme_code(
             vars_diff_code = ""
             if len(var_diffs) > 0:
                 vars_diff_code = f""".set(
-    {(',' + newline + "    ").join([f"{k}='{v}'" for k, v in var_diffs.items()])}
+    {("," + newline + "    ").join([f"{k}='{v}'" for k, v in var_diffs.items()])}
 )"""
 
             output = f"""

diff --git a/gradio/themes/utils/fonts.py b/gradio/themes/utils/fonts.py
@@ -73,7 +73,7 @@ def __init__(self, name: str, weights: Iterable[int] = (400, 600)):
         self.weights = weights
 
     def stylesheet(self) -> dict:
-        url = f'https://fonts.googleapis.com/css2?family={self.name.replace(" ", "+")}:wght@{";".join(str(weight) for weight in self.weights)}&display=swap'
+        url = f"https://fonts.googleapis.com/css2?family={self.name.replace(' ', '+')}:wght@{';'.join(str(weight) for weight in self.weights)}&display=swap"
         return {"url": url, "css": None}
 
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -145,6 +145,7 @@ ignore = [
   "PLR2004", # magic numbers
   "PLW2901", # `for` loop variable overwritten by assignment target
   "SIM105",  # contextlib.suppress (has a performance cost)
+  "SIM115",  # contextlib.suppress (has a performance cost)
   "SIM117",  # multiple nested with blocks (doesn't look good with gr.Row etc)
   "UP006",   # use `list` instead of `List` for type annotations (fails for 3.8)
   "UP007",   # use X | Y for type annotations (TODO: can be enabled once Pydantic plays nice with them)

diff --git a/requirements.txt b/requirements.txt
@@ -17,7 +17,7 @@ pydantic>=2.0
 python-multipart>=0.0.18 # required for fastapi forms.
 pydub
 pyyaml>=5.0,<7.0
-ruff>=0.2.2; sys.platform != 'emscripten'
+ruff>=0.9.3; sys.platform != 'emscripten'  # needed here for custom component docs generation
 safehttpx>=0.1.6,<0.2.0
 semantic_version~=2.0
 starlette>=0.40.0,<1.0; sys.platform != 'emscripten'

diff --git a/scripts/lint_backend.sh b/scripts/lint_backend.sh
@@ -2,5 +2,5 @@
 
 cd "$(dirname ${0})/.."
 python -c "import gradio"
-python -m ruff gradio test client
+python -m ruff check gradio test client
 python -m ruff format --check gradio test client
diff --git a/test/test_routes.py b/test/test_routes.py
@@ -1160,16 +1160,16 @@ class TestShowAPI:
     @patch.object(wasm_utils, "IS_WASM", True)
     def test_show_api_false_when_is_wasm_true(self):
         interface = Interface(lambda x: x, "text", "text", examples=[["hannah"]])
-        assert (
-            interface.show_api is False
-        ), "show_api should be False when IS_WASM is True"
+        assert interface.show_api is False, (
+            "show_api should be False when IS_WASM is True"
+        )
 
     @patch.object(wasm_utils, "IS_WASM", False)
     def test_show_api_true_when_is_wasm_false(self):
         interface = Interface(lambda x: x, "text", "text", examples=[["hannah"]])
-        assert (
-            interface.show_api is True
-        ), "show_api should be True when IS_WASM is False"
+        assert interface.show_api is True, (
+            "show_api should be True when IS_WASM is False"
+        )
 
 
 def test_component_server_endpoints(connect):
@@ -1344,7 +1344,7 @@ def fn_1(x):
             def fn_2(x):
                 for i in range(len(x)):
                     time.sleep(0.5)
-                    yield f"Hello, {x[:i+1]}!"
+                    yield f"Hello, {x[: i + 1]}!"
                 if len(x) < 3:
                     raise ValueError("Small input")