-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar Component #10435
Sidebar Component #10435
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/5d6e0c4c229c0f26d7250d5490a5c6d69f987c5d/gradio-5.13.2-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@5d6e0c4c229c0f26d7250d5490a5c6d69f987c5d#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/5d6e0c4c229c0f26d7250d5490a5c6d69f987c5d/gradio-client-1.10.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/5d6e0c4c229c0f26d7250d5490a5c6d69f987c5d/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Looks very nice @dawoodkhan82! Just one minor point: the toggle icon is hard to see in light mode: otherwise looks great! |
With the reduction of drop shadows in the overall gradio design updates, I'm wondering if you need a drop shadow. It might look a little bit weird without it initially, but if we implement the dynamic content shift then I think it will definitely look better |
Co-authored-by: Hannah <[email protected]>
Screen.Recording.2025-01-29.at.12.26.44.PM.movThis is not ideal, but I do understand why its happening (the dynamic shifting happens in onMount(), which happanes after the page is loaded). One potential workaround: what if the sidebar is initially closed but opens in onMount(), which means that it would open simultaneously with the dynamic shifting, which could lead to a nice effect actually?) |
Let's add some documentation about |
@@ -0,0 +1,23 @@ | |||
import { test, expect } from "@self/tootils"; | |||
|
|||
test("shows open sidebar and components in sidebar work", async ({ page }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
LGTM @dawoodkhan82, I only noticed one issue -- the footer is not visible when a sidebar is added. You have to scroll down to see it. Good to merge once that's addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really great @dawoodkhan82!
Description
Screen.Recording.2025-01-28.at.8.10.40.PM.mov
Closes: #9117
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh