Retrieve dashboard by name/title

[luixx]

Description

Coming from m0nhawk/grafana_api#91, there is the new function get_dashboard_by_name introduced so the dashboards can be found by name and not only id.

Checklist

• The patch has appropriate test coverage
• The patch follows the style guidelines of this project
• The patch has appropriate comments, particularly in hard-to-understand areas
• The documentation was updated corresponding to the patch
• I have performed a self-review of this patch

[codecov-commenter]

Codecov Report

Merging #9 (9b12c99) into main (ee27df3) will decrease coverage by 0.37%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   87.55%   87.17%   -0.38%     
==========================================
  Files          17       17              
  Lines         659      663       +4     
==========================================
+ Hits          577      578       +1     
- Misses         82       85       +3     

Impacted Files	Coverage Δ
grafana_client/elements/dashboard.py	92.68% <25.00%> (-7.32%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa73dc...9b12c99. Read the comment docs.

[amotl]

Dear @luixx,

thanks a stack for your contribution. Do you believe you can add a corresponding test case?

With kind regards,
Andreas.

[luixx]

Dear @luixx,

thanks a stack for your contribution. Do you believe you can add a corresponding test case?

With kind regards, Andreas.

Hi, yes i will do this. It probabl takes a little bit.

Greetings Karsten

[amotl]

Hi Karsten,

thank you for adding a test case. Currently, it croaks on this line with AttributeError: 'Dashboard' object has no attribute 'api' ¹.

While refactoring the package, we slightly changed its internals, so on this spot, self.api became self.client:

Suggested change

	r = self.api.GET(get_dashboard_path)
	r = self.client.GET(get_dashboard_path)

Can you amend your patch correspondingly? If everything goes right after that, the tests should succeed ².

With kind regards,
Andreas.

Footnotes

1. https://github.com/panodata/grafana-client/runs/5128322276 ↩

2. In order to verify it, you can run the test suite on your workstation, like documented in the README ³.
   If that is not possible, you can also inspect the outcome from the test suite by following the links in the "checks" section below.
   ↩

3. https://github.com/panodata/grafana-client#software-tests ↩

[luixx]

So, i hope everything is fine now.

[amotl]

So, i hope everything is fine now.

Excellent. Thank you again!

[amotl]

Dear Karsten,

we just relased grafana-client==2.2.0, including your contribution. Thank you again!

With kind regards,
Andreas.