Grafana 8: Don't croak when unable to load/access KeybindingSrv #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this addresses #103.
Apparently, the KeybindingSrv service component will have to be addressed differently on Grafana 8. By now, the first patch 86d5db3 will just ignore / skip anything related to that, so we only lack minor functionality about »disabling keyboard navigation completely«, aka. the
ignoreEscapeKey
feature.While this is a start, there might be more issues we will be running into, so we will be happy to receive any further reports from the community. Would someone also be available to verify this by building that branch using
npx yarn dev
and linking thedist
folder into the Grafana plugin folder in order to check if the plugin with those improvements will actually work on real data?With kind regards,
Andreas.
/cc @jm66, @MarcoPignati