Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move context retrieval under mutex lock in concurrent eval #2648

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move context retrieval under mutex lock in concurrent eval #2648

wants to merge 3 commits into from
+4 −2

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Feb 7, 2025

PR Description

There was a small window where a component would copy the context during the re-evaluation process. This led to the component being evaluated without all the data needed and logged errors.

PR Checklist

  • CHANGELOG.md updated
  • [na] Documentation added
  • Tests updated -> bit hard to test given the time sensitivity
  • [na] Config converters updated

@wildum wildum requested a review from a team as a code owner February 7, 2025 14:38
mattdurham
mattdurham approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

thampiotr
thampiotr approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Would be good to follow up with some test that would at least be sometimes flaky without this fix? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdurham mattdurham mattdurham approved these changes

@thampiotr thampiotr thampiotr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wildum @mattdurham @thampiotr