fix: update BUILDINFO_PKG to v2 in Makefile #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
==========================================
+ Coverage 69.64% 69.69% +0.05%
==========================================
Files 209 209
Lines 20975 20975
==========================================
+ Hits 14608 14619 +11
+ Misses 5661 5653 -8
+ Partials 706 703 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
pushed a commit
that referenced
this pull request
Feb 20, 2025
marctc
added a commit
that referenced
this pull request
Feb 21, 2025
Co-authored-by: icylord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the
github.com/grafana/beyla/pkg/buildinfowas changed togithub.com/grafana/beyla/v2/pkg/buildinfoin this commit(3c4e678), but the Makefile still uses old name, this will cause theVersionandRevisionto not be properly set.Below are the logs from the grafana/beyla:2.0.5: