fix(cloud/stack): default to Slug for external-name #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/cloud_stack_external_name
branch
from
7cc7685 to
2ccb136
Compare
Duologic
force-pushed
the
duologic/cloud_stack_external_name
branch
from
2ccb136 to
c5e44a0
Compare
Duologic
force-pushed
the
duologic/cloud_stack_external_name
branch
from
c5e44a0 to
8c8f180
Compare
alexander-bauer
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently when a resource has configured an external-name with a slug, Crossplane will happily import it be afterwards change the external-name to the ID, this'll flip-flop when using a composition or flux to create this resource.
As Cloud Stacks can either be imported by ID or by Slug, we'll default to slug instead of ID as the ID can't be known upfront. This'll allow us to import existing instances more consistently.
Also see: https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/cloud_stack#import
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I'm planning to run this in a dev cluster soon after merge.
For reviewers
config/has the configuration for theupjetcode generatordocs for the change in this PR can be read here: https://github.com/crossplane/upjet/blob/main/docs/configuring-a-resource.md and here: https://pkg.go.dev/github.com/crossplane/[email protected]/pkg/config#ExternalName