Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(promtail): Fix API level node filtering of Kubernetes SD to only fetch pod metadata for pods of the current node #14267

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

LashaJini
Copy link
Contributor

@LashaJini LashaJini commented Sep 25, 2024

What this PR does / why we need it:

Previous behavior: loop variable selector is a copy of each element, thus changes to the fields is not reflected in the original slice.

Current behavior: use index of the element and update directly.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@LashaJini LashaJini marked this pull request as ready for review September 25, 2024 16:23
@LashaJini LashaJini requested a review from a team as a code owner September 25, 2024 16:23
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Sep 26, 2024
@LashaJini LashaJini force-pushed the correctly-loop-over-k8s-selectors branch from c7c6748 to 8a218cb Compare September 26, 2024 08:36
@LashaJini LashaJini requested a review from chaudum September 26, 2024 08:46
defer client.Stop()

ftm, err := newTestFileTargetManager(logger, client, ps, logDirName+"/*")
assert.NoError(t, err)
Copy link
Contributor Author

@LashaJini LashaJini Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the missing err assertion to satisfy the linter

@LashaJini
Copy link
Contributor Author

@chaudum could you please remove the invalid labels. I've accidentally pushed the wrong changes and gh actions bot didn't remove the invalid ones.

@chaudum chaudum added component/promtail and removed area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Dec 13, 2024
@chaudum chaudum changed the title fix: Correct loop in kube pod selector fix(promtail): Correct loop in kube pod selector Dec 13, 2024
@chaudum chaudum changed the title fix(promtail): Correct loop in kube pod selector fix(promtail): Fix API level node filtering of Kubernetes SD to only fetch pod metadata for pods of the current node Dec 13, 2024
@chaudum chaudum merged commit d2b6fd8 into grafana:main Jan 10, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants