-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(promtail): Fix API level node filtering of Kubernetes SD to only fetch pod metadata for pods of the current node #14267
fix(promtail): Fix API level node filtering of Kubernetes SD to only fetch pod metadata for pods of the current node #14267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
c7c6748
to
8a218cb
Compare
defer client.Stop() | ||
|
||
ftm, err := newTestFileTargetManager(logger, client, ps, logDirName+"/*") | ||
assert.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the missing err
assertion to satisfy the linter
@chaudum could you please remove the invalid labels. I've accidentally pushed the wrong changes and gh actions bot didn't remove the invalid ones. |
What this PR does / why we need it:
Previous behavior: loop variable
selector
is a copy of each element, thus changes to the fields is not reflected in the original slice.Current behavior: use index of the element and update directly.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR