-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Logcli tutorial and sandbox #15152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I think another section we could add is batch querying lots of logs. This is something logcli
is great for, that you can't actually do well in another tool like Grafana.
Co-authored-by: Trevor Whitney <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Docs team] I haven't had a chance to walk through the killercoda tutorial yet, I've just read through the text, but wanted to give you the feedback ASAP.
Co-authored-by: J Stickler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had time to run through the sandbox today. There were a couple of odd results....
Hi @JStickler so sorry i forgot to mention I was at Reinvent fully agree with your original review so still fixing those comments and let me check to see what is happening with the killercoda scenario as I am also seeing that but not locally. |
Hi @JStickler, that should be the edit complete and the suggestions added. Just a couple of things to note:
Here is the updated sandbox for your review: https://killercoda.com/grafana-dev-testing/course/loki/logcli-tutorial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Spotted a couple more things on this review, but I think we're getting very close to finished.
Hi @JStickler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team]
Co-authored-by: J Stickler <[email protected]>
Changes ready and waiting for your review @JStickler :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
Co-authored-by: Trevor Whitney <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 1b4363a)
Co-authored-by: Trevor Whitney <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 1b4363a)
What this PR does / why we need it:
This sandbox adds a new LogCLI tutorial based on a fun scenario using logs themed from a logistics centre.
The PR also modifies the directory structure to accommodate and adds the
detected-fields
option to the reference.Here is the sandbox to try: https://killercoda.com/grafana-dev-testing/course/loki/logcli-tutorial
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR