Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ksonnet): add configs to use thanos object store #16030

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:

Adds support for loki ksonnet to configure thanos object store clients. It configures ruler storage to use the same bucket as chunks, it is upto the user to override this in their installations if they prefer to have a different bucket for rules

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner January 31, 2025 12:03
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 31, 2025
Copy link
Contributor

@fcjack fcjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit f524dfd into main Feb 3, 2025
62 checks passed
@ashwanthgoli ashwanthgoli deleted the ksonnet-use-thanos branch February 3, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants