chore(dataobj): do not panic on unrecognized compression type #16088
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening a page for reading should not cause a panic. An unknown compression type may be encountered if an older version of the dataobj reading code is trying to read an object produced by a newer version (where new compression types are available). Because of this, the read path should never panic when encountering an unexpected value in an object; this was the only panic on the read path and is now removed.
benclive
approved these changes
Feb 4, 2025
owen-d
approved these changes
Feb 4, 2025
grobinson-grafana
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a page for reading should not cause a panic. An unknown compression type may be encountered if an older version of the dataobj reading code is trying to read an object produced by a newer version (where new compression types are available).
Because of this, the read path should never panic when encountering an unexpected value in an object; this was the only panic on the read path and is now removed.