-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block builder: update alerts and add critical alerts #10270
Conversation
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about having two of each kind of alerts.
E.g. the "no cycles" two: to have only 10 minutes gap between a warning and a critical alert is a fairly small window for a person, who'll be paged, to do any meaningful investigations.
I suggest we only keep one but make sure the for
is long enough to be critical.
Fair point! We can probably just keep a critical alert for 20 mins and remove the warning for 10 mins. |
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
I updated the PR and the description. I removed the Remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M.
Signed-off-by: Ganesh Vernekar <[email protected]>
What this PR does
Updated some warnings and add critical alerts to block builders.
BlockBuilderNoCycleProcessing
is a little sensitive. Meaning if a consumption ran a little longer than 5m compared to the earlier one (for duration is 5m), this alert will fire. Made thefor
period to be 20 minsBlockBuilderLagging
current warning alert fires when the lag is over 4M for 75mins (basically lag went above 4M, but it stayed above 4M in the next cycle as well). We have a critical alert with for duration of 2h20m. Meaning once it went above 4M in a cycle, it remained about 4M in the next two cycles as well. If the cycle run was not successful, thenBlockBuilderNoCycleProcessing
will already fire much the lagging alert will fire.BlockBuilderLagging
will catch other issues that is not just "not able to consume", like block builders are not scaled enough for example.BlockBuilderCompactAndUploadFailed
fired, it should be a critical alert immediately. Removed thefor
period.Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.