MQE: Tidy up pool size handling #10372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily from feedback on grafana#10261 Rather than allowing an arbitrary maxSize in pools, require them to be a power of two since that is what happens internally anyway. We keep the checks and protections around requiring it to be a power of two.
charleskorn
approved these changes
Jan 9, 2025
| @@ -86,11 +87,15 @@ func (p *BucketedPool[T, E]) Put(s T) { | |||
| return // Ignore slices larger than the largest bucket | |||
There was a problem hiding this comment.
Should we note here that we expect this will never happen given the maxSize check a few lines above and the fact that maxSize should be a power of two?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily from feedback on #10261
Rather than allowing an arbitrary maxSize in pools, require them to be a power of two since that is what happens internally anyway.
We keep the checks and protections around requiring it to be a power of two.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.