Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard panels for ingester reactive limiters #10590

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

jhalterman
Copy link
Member

@jhalterman jhalterman commented Feb 6, 2025

What this PR does

This PR adds dashboard panels for ingester reactive limiters, which are being introduced via #10574.

The Mimir / Writes dashboard had some panels added to and below the existing Instance Limits row:

Screenshot 2025-02-05 at 5 02 20 PM

And the Mimir / Reads dashboard had a new Instance Limits row added:

Screenshot 2025-02-05 at 5 02 13 PM

These can be enabled via show_reactive_limiter_panels: true.

Which issue(s) this PR fixes or relates to

Depends on #10574

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhalterman jhalterman force-pushed the adaptivelimiter-dashboard branch from 1d8da92 to 4dfb524 Compare February 6, 2025 01:15
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhalterman jhalterman force-pushed the adaptivelimiter-dashboard branch from 0bdc4b4 to e02b7b6 Compare February 6, 2025 04:20
@jhalterman jhalterman force-pushed the adaptivelimiter-dashboard branch from e02b7b6 to 9baf4ee Compare February 6, 2025 05:25
@jhalterman jhalterman changed the title Add dashboard panels for ingester adaptive limiters Add dashboard panels for ingester reactive limiters Feb 7, 2025
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These panels seem fine but it doesn't seem like the metrics we're emitting are correct.

@jhalterman jhalterman merged commit 73090ba into grafana:main Feb 13, 2025
32 checks passed
@jhalterman jhalterman deleted the adaptivelimiter-dashboard branch February 13, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants