-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass redis SSL config to connection pool #5220
base: dev
Are you sure you want to change the base?
Conversation
d59c342
to
3535fca
Compare
We are running into the same problem trying to use oncall with a Redis on GCP with in-transit encryption enabled. |
3535fca
to
ba679eb
Compare
We have Grafana OnCall deployed using a Helm chart. As a workaround, I added the following env variable:
Redis CA cert is mounted to It would be nice to get this merged. Created this PR almost a month ago, no feedback so far. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
ba679eb
to
1327c3a
Compare
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
What this PR does
This fix will pass SSL config properly to redis connection pool.
django-redis passes
CONNECTION_POOL_KWARGS
and notCONNECTION_POOL_CLASS_KWARGS
to connection pool class, related django-redis code can be seen here.Also, without this fix other settings
max_connections
andtimeout
are also not passed to connection pool.I had issues with external Redis with in-transit encryption enabled using self-signed certs (Google managed Redis).
After changing this I can properly pass self-signed CA cert to redis client using
REDIS_SSL_CA_CERTS
env variable.Which issue(s) this PR closes
There is no issue created for this problem.
Checklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.